On Wed, 1 Dec 2021 at 15:40, Francisco Iglesias <francisco.igles...@xilinx.com> wrote: > > Connect the OSPI flash memory controller model (including the source and > destination DMA). > > Signed-off-by: Francisco Iglesias <francisco.igles...@xilinx.com> > Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > --- > hw/arm/xlnx-versal.c | 88 > ++++++++++++++++++++++++++++++++++++++++++++ > include/hw/arm/xlnx-versal.h | 20 ++++++++++ > 2 files changed, 108 insertions(+)
> + /* OSPI irq */ > + object_initialize_child(OBJECT(s), "ospi-irq", > + &s->pmc.iou.ospi.irq, TYPE_OR_IRQ); Can you give this device a name with "OR" in it, eg "ospi-or-irq" or "ospi-or-gate" or something, please? "ospi-irq" suggests it's just a single IRQ line. Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM