qemu-common.h has a comment at the top: * This file is supposed to be included only by .c files. No header file should * depend on qemu-common.h, as this would easily lead to circular header * dependencies.
We still have a few .h files which include it, though. The first 3 patches in this series fix that: in 3 out of 4 cases we didn't need the #include at all, and in the 4th case we can instead #include qemu-common.h from just one .c file. Patch 4 is just removing the #include from 8 files in hw/arm which don't need it at all. (Probably there are other files like this, but I just did the Arm related ones.) Tested by pushing to gitlab for the CI build. -- PMM Peter Maydell (4): include/hw/i386: Don't include qemu-common.h in .h files target/hexagon/cpu.h: don't include qemu-common.h target/rx/cpu.h: Don't include qemu-common.h hw/arm: Don't include qemu-common.h unnecessarily include/hw/i386/microvm.h | 1 - include/hw/i386/x86.h | 1 - target/hexagon/cpu.h | 1 - target/rx/cpu.h | 1 - hw/arm/boot.c | 1 - hw/arm/digic_boards.c | 1 - hw/arm/highbank.c | 1 - hw/arm/npcm7xx_boards.c | 1 - hw/arm/sbsa-ref.c | 1 - hw/arm/stm32f405_soc.c | 1 - hw/arm/vexpress.c | 1 - hw/arm/virt.c | 1 - linux-user/hexagon/cpu_loop.c | 1 + 13 files changed, 1 insertion(+), 12 deletions(-) -- 2.25.1
