On Wed, 24 Nov 2021 at 10:16, Francisco Iglesias <francisco.igles...@xilinx.com> wrote: > > Connect Versal's PMC SLCR (system-level control registers) model. > > Signed-off-by: Francisco Iglesias <francisco.igles...@xilinx.com> > Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > --- > hw/arm/xlnx-versal.c | 18 ++++++++++++++++++ > include/hw/arm/xlnx-versal.h | 6 ++++++ > 2 files changed, 24 insertions(+) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index b2705b6925..08e250945f 100644 > --- a/hw/arm/xlnx-versal.c > +++ b/hw/arm/xlnx-versal.c > @@ -369,6 +369,23 @@ static void versal_create_efuse(Versal *s, qemu_irq *pic) > sysbus_connect_irq(SYS_BUS_DEVICE(ctrl), 0, pic[VERSAL_EFUSE_IRQ]); > } > > +static void versal_create_pmc_iou_slcr(Versal *s, qemu_irq *pic) > +{ > + SysBusDevice *sbd; > + > + object_initialize_child(OBJECT(s), "versal-pmc-iou-slcr", > &s->pmc.iou.slcr, > + TYPE_XILINX_VERSAL_PMC_IOU_SLCR); > + > + sbd = SYS_BUS_DEVICE(&s->pmc.iou.slcr); > + sysbus_realize(sbd, &error_fatal); > + > + memory_region_add_subregion(&s->mr_ps, MM_PMC_PMC_IOU_SLCR, > + sysbus_mmio_get_region(sbd, 0));
Nit: the indent here is wrong. Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM