On Wed, Oct 27, 2021 at 8:14 AM Alistair Francis <alistai...@gmail.com>
wrote:
> On Mon, Oct 25, 2021 at 10:51 PM Rahul Pathak <rpat...@ventanamicro.com>
> wrote:
> >
> > Patches add the mconfigptr csr support.
> > mconfigptr is newly incorporated in risc-v privileged architecture
> > specification 1.12 version.
> > priv spec 1.12.0 version check is also added.
> >
> >
> > qemu-system-riscv64 -nographic -machine virt -cpu rv64,priv_spec=v1.12.0
>
> Thanks for the patches!
>
> I gave some comments in line with the code changes. Overall this looks
> good, we just need to add the other v1.12.0 features.
>
> Alistair
Thanks Alistair, I will work on the comments and send the
next version.
>
>
>
> > Changelog:
> >
> > v1->v2
> > ------
> > 1. Added privileged architecture spec version 1.12 ("v1.12.0") check
> > 2. Added predicate function for mconfigptr which verifies
> > for priv spec version v1.12.0 or higher.
> >
> > Thanks
> > Rahul
> >
> > Rahul Pathak (2):
> > target/riscv: Add priv spec 1.12.0 version check
> > target/riscv: csr: Implement mconfigptr CSR
> >
> > target/riscv/cpu.c | 4 +++-
> > target/riscv/cpu.h | 1 +
> > target/riscv/cpu_bits.h | 1 +
> > target/riscv/csr.c | 19 +++++++++++++++----
> > 4 files changed, 20 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1
> >
> >
>
