On Fri, Oct 22, 2021 at 2:02 PM Alistair Francis
<alistair.fran...@opensource.wdc.com> wrote:
>
> From: Alistair Francis <alistair.fran...@wdc.com>
>
> Signed-off-by: Alistair Francis <alistair.fran...@wdc.com>
> ---
> hw/riscv/sifive_u.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
> index fc5790b8ce..0010b404ee 100644
> --- a/hw/riscv/sifive_u.c
> +++ b/hw/riscv/sifive_u.c
> @@ -813,7 +813,6 @@ static void sifive_u_soc_realize(DeviceState *dev, Error
> **errp)
> MemoryRegion *mask_rom = g_new(MemoryRegion, 1);
> MemoryRegion *l2lim_mem = g_new(MemoryRegion, 1);
> char *plic_hart_config;
> - size_t plic_hart_config_len;
> int i, j;
> NICInfo *nd = &nd_table[0];
>
> @@ -854,18 +853,7 @@ static void sifive_u_soc_realize(DeviceState *dev, Error
> **errp)
> l2lim_mem);
>
> /* create PLIC hart topology configuration string */
> - plic_hart_config_len = (strlen(SIFIVE_U_PLIC_HART_CONFIG) + 1) *
SIFIVE_U_PLIC_HART_CONFIG should be removed from sifive_u.h
> - ms->smp.cpus;
> - plic_hart_config = g_malloc0(plic_hart_config_len);
> - for (i = 0; i < ms->smp.cpus; i++) {
> - if (i != 0) {
> - strncat(plic_hart_config, "," SIFIVE_U_PLIC_HART_CONFIG,
> - plic_hart_config_len);
> - } else {
> - strncat(plic_hart_config, "M", plic_hart_config_len);
> - }
> - plic_hart_config_len -= (strlen(SIFIVE_U_PLIC_HART_CONFIG) + 1);
> - }
> + plic_hart_config = riscv_plic_hart_config_string(ms->smp.cpus);
>
> /* MMIO */
> s->plic = sifive_plic_create(memmap[SIFIVE_U_DEV_PLIC].base,
> --
Otherwise,
Reviewed-by: Bin Meng <bmeng...@gmail.com>
Tested-by: Bin Meng <bmeng...@gmail.com>
