On Fri, Oct 22, 2021 at 6:38 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > On 10/22/21 08:01, Alistair Francis wrote: > > From: Alistair Francis <alistair.fran...@wdc.com> > > > > Using a macro for the PLIC configuration doesn't make the code any > > easier to read. Instead it makes it harder to figure out what is going > > on, so let's remove it. > > > > Signed-off-by: Alistair Francis <alistair.fran...@wdc.com> > > Reviewed-by: Bin Meng <bmeng...@gmail.com> > > --- > > include/hw/riscv/virt.h | 1 - > > hw/riscv/virt.c | 2 +- > > 2 files changed, 1 insertion(+), 2 deletions(-) > > No cover letter, so using the first patch.
It's also better to include a changelog in each patch otherwise it's hard to track what has changed compared to v1, especially the v1 was posted 1.5 months ago. > > Series: > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Regards, Bin