On 10/21/21 12:42 PM, Peter Xu wrote:
> They're actually more commonly used than the helper without _under_bus,
> because
> most callers do have the pci bus on hand. After exporting we can switch a lot
> of the call sites to use these two helpers.
>
> Signed-off-by: Peter Xu <pet...@redhat.com>
> ---
> hw/pci/pci.c | 10 +++++-----
> include/hw/pci/pci.h | 5 +++++
> 2 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 1ab2b78321..6b834cace5 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1654,9 +1654,9 @@ static const pci_class_desc pci_class_descriptions[] =
> { 0, NULL}
> };
>
> -static void pci_for_each_device_under_bus_reverse(PCIBus *bus,
> - pci_bus_dev_fn fn,
> - void *opaque)
> +void pci_for_each_device_under_bus_reverse(PCIBus *bus,
> + pci_bus_dev_fn fn,
> + void *opaque)
> {
> PCIDevice *d;
> int devfn;
> @@ -1679,8 +1679,8 @@ void pci_for_each_device_reverse(PCIBus *bus, int
> bus_num,
> }
> }
>
> -static void pci_for_each_device_under_bus(PCIBus *bus,
> - pci_bus_dev_fn fn, void *opaque)
> +void pci_for_each_device_under_bus(PCIBus *bus,
> + pci_bus_dev_fn fn, void *opaque)
> {
> PCIDevice *d;
> int devfn;
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 8e2d80860b..437eabe609 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -465,6 +465,11 @@ void pci_for_each_device(PCIBus *bus, int bus_num,
> void pci_for_each_device_reverse(PCIBus *bus, int bus_num,
> pci_bus_dev_fn fn,
> void *opaque);
> +void pci_for_each_device_under_bus(PCIBus *bus,
> + pci_bus_dev_fn fn, void *opaque);
> +void pci_for_each_device_under_bus_reverse(PCIBus *bus,
> + pci_bus_dev_fn fn,
> + void *opaque);
> void pci_for_each_bus_depth_first(PCIBus *bus,
> void *(*begin)(PCIBus *bus, void
> *parent_state),
> void (*end)(PCIBus *bus, void *state),
Reviewed-by: Eric Auger <eric.au...@redhat.com>
Eric
