On Sun, Sep 26, 2021 at 4:31 PM Bin Meng <bmeng...@gmail.com> wrote:
>
> On Sat, Sep 25, 2021 at 9:34 PM Philippe Mathieu-Daudé <f4...@amsat.org>
> wrote:
> >
> > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the
> > size occupied by all the registers. However all registers are
> > 32-bit wide, and the MemoryRegionOps handlers are restricted to
> > 32-bit:
> >
> > static const MemoryRegionOps mchp_pfsoc_mmuart_ops = {
> > .read = mchp_pfsoc_mmuart_read,
> > .write = mchp_pfsoc_mmuart_write,
> > .impl = {
> > .min_access_size = 4,
> > .max_access_size = 4,
> > },
> >
> > Avoid being triskaidekaphobic, simplify by using the number of
>
> typo? See https://www.dictionary.com/browse/triskaidekaphobia
>
> Learned a new word today but I have to say this word is too hard for a
> non-native speaker :)
>
Never mind, triskaidekaphobia is a noun, and triskaidekaphobic is the
adjective which is grammarly correct :)
> > registers.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> > ---
> > include/hw/char/mchp_pfsoc_mmuart.h | 4 ++--
> > hw/char/mchp_pfsoc_mmuart.c | 14 ++++++++------
> > 2 files changed, 10 insertions(+), 8 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bin.m...@windriver.com>
> Tested-by: Bin Meng <bin.m...@windriver.com>
Regards,
Bin
