On Mon, Sep 13, 2021 at 02:39:29PM +0200, Markus Armbruster wrote: > Replace simple union __org.qemu_x-Union1 flat union
missing 'with' > __org.qemu_x-Union2, except drop it from __org.qemu_x-command, because > there it's only used to pull it into QMP. Now drop the unused simple > union. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > tests/unit/test-qmp-cmds.c | 16 +++++----------- > tests/qapi-schema/qapi-schema-test.json | 6 ++---- > tests/qapi-schema/qapi-schema-test.out | 14 +++----------- > 3 files changed, 10 insertions(+), 26 deletions(-) > Looks a bit odd to leave things with Union2 but not Union1; up to you if it is worth a further cleanup to rename what remains to get rid of the odd gap. I don't think it's a show-stopper for your series to keep the naming as-is, though. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
