Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- include/tcg/tcg-module-i386.h | 2 ++ target/i386/cpu.h | 3 --- accel/tcg/tcg-module-i386.c | 1 + target/i386/cpu-dump.c | 2 +- target/i386/gdbstub.c | 2 +- target/i386/tcg/fpu_helper.c | 5 +++-- target/i386/tcg/tcg-stub.c | 25 ------------------------- target/i386/tcg/meson.build | 2 -- 8 files changed, 8 insertions(+), 34 deletions(-) delete mode 100644 target/i386/tcg/tcg-stub.c
diff --git a/include/tcg/tcg-module-i386.h b/include/tcg/tcg-module-i386.h index 5d8f6434e32d..576e0a63f01f 100644 --- a/include/tcg/tcg-module-i386.h +++ b/include/tcg/tcg-module-i386.h @@ -4,6 +4,8 @@ struct TCGI386ModuleOps { void (*update_fp_status)(CPUX86State *env); void (*update_mxcsr_status)(CPUX86State *env); + void (*update_mxcsr_from_sse_status)(CPUX86State *env); + }; extern struct TCGI386ModuleOps tcg_i386; diff --git a/target/i386/cpu.h b/target/i386/cpu.h index bdfdbdb0d8a8..deba8eb04d1f 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2127,9 +2127,6 @@ static inline bool cpu_vmx_maybe_enabled(CPUX86State *env) /* excp_helper.c */ int get_pg_mode(CPUX86State *env); -/* fpu_helper.c */ -void update_mxcsr_from_sse_status(CPUX86State *env); - static inline void cpu_set_mxcsr(CPUX86State *env, uint32_t mxcsr) { env->mxcsr = mxcsr; diff --git a/accel/tcg/tcg-module-i386.c b/accel/tcg/tcg-module-i386.c index fa455a2e02cb..6908fe34cef6 100644 --- a/accel/tcg/tcg-module-i386.c +++ b/accel/tcg/tcg-module-i386.c @@ -8,4 +8,5 @@ static void i386_update_cpu_stub(CPUX86State *cpu) struct TCGI386ModuleOps tcg_i386 = { .update_fp_status = i386_update_cpu_stub, .update_mxcsr_status = i386_update_cpu_stub, + .update_mxcsr_from_sse_status = i386_update_cpu_stub, }; diff --git a/target/i386/cpu-dump.c b/target/i386/cpu-dump.c index 02b635a52cff..cce9110705c7 100644 --- a/target/i386/cpu-dump.c +++ b/target/i386/cpu-dump.c @@ -487,7 +487,7 @@ void x86_cpu_dump_state(CPUState *cs, FILE *f, int flags) for(i = 0; i < 8; i++) { fptag |= ((!env->fptags[i]) << i); } - update_mxcsr_from_sse_status(env); + tcg_i386.update_mxcsr_from_sse_status(env); qemu_fprintf(f, "FCW=%04x FSW=%04x [ST=%d] FTW=%02x MXCSR=%08x\n", env->fpuc, (env->fpus & ~0x3800) | (env->fpstt & 0x7) << 11, diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index 098a2ad15a9c..e73125dbe9e2 100644 --- a/target/i386/gdbstub.c +++ b/target/i386/gdbstub.c @@ -190,7 +190,7 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) return gdb_get_reg32(mem_buf, 0); /* fop */ case IDX_MXCSR_REG: - update_mxcsr_from_sse_status(env); + tcg_i386.update_mxcsr_from_sse_status(env); return gdb_get_reg32(mem_buf, env->mxcsr); case IDX_CTL_CR0_REG: diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c index 12dd6c9a65df..9a0d1798985b 100644 --- a/target/i386/tcg/fpu_helper.c +++ b/target/i386/tcg/fpu_helper.c @@ -2534,7 +2534,7 @@ static void do_xsave_fpu(CPUX86State *env, target_ulong ptr, uintptr_t ra) static void do_xsave_mxcsr(CPUX86State *env, target_ulong ptr, uintptr_t ra) { - update_mxcsr_from_sse_status(env); + tcg_i386.update_mxcsr_from_sse_status(env); cpu_stl_data_ra(env, ptr + XO(legacy.mxcsr), env->mxcsr, ra); cpu_stl_data_ra(env, ptr + XO(legacy.mxcsr_mask), 0x0000ffff, ra); } @@ -2985,7 +2985,7 @@ static void update_mxcsr_status(CPUX86State *env) set_flush_to_zero((mxcsr & SSE_FZ) ? 1 : 0, &env->sse_status); } -void update_mxcsr_from_sse_status(CPUX86State *env) +static void update_mxcsr_from_sse_status(CPUX86State *env) { uint8_t flags = get_float_exception_flags(&env->sse_status); /* @@ -3044,6 +3044,7 @@ static void tcgi386_module_ops_fpu(void) { tcg_i386.update_fp_status = update_fp_status; tcg_i386.update_mxcsr_status = update_mxcsr_status; + tcg_i386.update_mxcsr_from_sse_status = update_mxcsr_from_sse_status; } type_init(tcgi386_module_ops_fpu); diff --git a/target/i386/tcg/tcg-stub.c b/target/i386/tcg/tcg-stub.c deleted file mode 100644 index 8d45579ada25..000000000000 --- a/target/i386/tcg/tcg-stub.c +++ /dev/null @@ -1,25 +0,0 @@ -/* - * x86 FPU, MMX/3DNow!/SSE/SSE2/SSE3/SSSE3/SSE4/PNI helpers - * - * Copyright (c) 2003 Fabrice Bellard - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, see <http://www.gnu.org/licenses/>. - */ - -#include "qemu/osdep.h" -#include "cpu.h" - -void update_mxcsr_from_sse_status(CPUX86State *env) -{ -} diff --git a/target/i386/tcg/meson.build b/target/i386/tcg/meson.build index 7bbe3d926975..8162511e6dac 100644 --- a/target/i386/tcg/meson.build +++ b/target/i386/tcg/meson.build @@ -1,5 +1,3 @@ -i386_softmmu_ss.add(when: 'CONFIG_TCG', if_false: files('tcg-stub.c')) - files_ss = ss.source_set() files_ss.add(when: 'CONFIG_TCG', if_true: files( 'bpt_helper.c', -- 2.31.1