On Wed, Aug 25, 2021 at 01:26:09PM +0200, Stefan Reiter wrote: > > It's not something done with other commands afaik, feels a bit awkward (the > > "connected = display"...). > > > > Indeed, if there is a better way I'd love to use it. > > One idea I had was making the parameter 'connected' OR 'display', since > the former only supports 'keep' for VNC anyway - but that introduces a > weird double-meaning again.
That's not too bad. See for example hmp_hostfwd_add, which merely names its two arguments arg1 and arg2. Naming your argument 'arg' instead of 'connected' or 'display' lets you interpret it in whatever context-sensitive manner is easiest for your use case. > > Is it really necessary to add support for HMP? > > > > For us it would be, as we provide an easy HMP interface to our users, but > not a QMP one, so it ended up being a bit of a regression with 6.0. Okay, you do have a point that until users can reliably use QMP to do the same, then keeping pre-existing HMP commands working is worthwhile. But long-term HMP stability is not an end goal. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
