Both dump-guest-memory and live migration have vm state cached internally. Allowing them to happen together means the vm state can be messed up. Simply block live migration for dump-guest-memory.
One trivial thing to mention is we should still allow dump-guest-memory even if -only-migratable is specified, because that flag should majorly be used to guarantee not adding devices that will block migration by accident. Dump guest memory is not like that - it'll only block for the seconds when it's dumping. Thanks, Peter Xu (2): migration: Add migrate_add_blocker_internal() dump-guest-memory: Block live migration dump/dump.c | 20 +++++++++++++++----- include/migration/blocker.h | 16 ++++++++++++++++ include/sysemu/dump.h | 1 + migration/migration.c | 21 +++++++++++++-------- 4 files changed, 45 insertions(+), 13 deletions(-) -- 2.31.1
