On Fri, Aug 13, 2021 at 04:05:04PM +0100, Peter Maydell wrote:
> Zero-initialize sockaddr_in and sockaddr_un structs that we're about
> to fill in and pass to bind() or connect(), to ensure we don't leave
> possible implementation-defined extension fields as uninitialized
> garbage.
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> gdbstub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 52bde5bdc97..5d8e6ae3cd9 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -3218,7 +3218,7 @@ static bool gdb_accept_socket(int gdb_fd)
>
> static int gdbserver_open_socket(const char *path)
> {
> - struct sockaddr_un sockaddr;
> + struct sockaddr_un sockaddr = {};
I know we use this non-standard form (which both gcc and clang accept)
because at least older versions of clang needlessly warn on the
standard C construct {0} in some situations, but figuring out when we
no longer support those older compilers and converting our code-base
to look more like standardized code is not my priority.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
