On 7/20/21 2:54 PM, Markus Armbruster wrote: > vhost_user_backend_init() can fail without setting an error. Unclean. > Its caller vhost_dev_init() compensates by substituting a generic > error then. Goes back to commit 28770ff935 "vhost: Distinguish errors > in vhost_backend_init()". > > Clean up by moving the generic error from vhost_dev_init() to all the > failure paths that neglect to set an error. > > Cc: Kevin Wolf <kw...@redhat.com> > Cc: Michael S. Tsirkin <m...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/virtio/vhost-user.c | 6 ++++++ > hw/virtio/vhost.c | 4 ---- > 2 files changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>