On 7/20/21 2:54 PM, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer points to NULL for the second > call. > > machine_parse_property_opt() is wrong that way: it passes @errp to > keyval_parse() without checking for failure, then passes it to > keyval_merge(). Harmless, since the only caller passes &error_fatal. > > Clean up: drop the parameter, and use &error_fatal directly. > > Cc: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > softmmu/vl.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
