On 13/07/2021 18.42, Philippe Mathieu-Daudé wrote:
+Alex
On 7/13/21 11:31 AM, Thomas Huth wrote:
A typo prevents that many features get disabled when the user
runs "configure" with the --without-default-features switch.
Reported-by: Cole Robinson <crobi...@redhat.com>
Signed-off-by: Thomas Huth <th...@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 85db248ac1..229ea52516 100755
--- a/configure
+++ b/configure
@@ -5205,7 +5205,7 @@ if test "$skip_meson" = no; then
-Ddocs=$docs -Dsphinx_build=$sphinx_build -Dinstall_blobs=$blobs \
-Dvhost_user_blk_server=$vhost_user_blk_server
-Dmultiprocess=$multiprocess \
-Dfuse=$fuse -Dfuse_lseek=$fuse_lseek
-Dguest_agent_msi=$guest_agent_msi -Dbpf=$bpf\
- $(if test "$default_features" = no; then echo
"-Dauto_features=disabled"; fi) \
+ $(if test "$default_feature" = no; then echo
"-Dauto_features=disabled"; fi) \
The option should be name plural (default_features)...
I agree with Markus - the way it is used in the configure script, it's
rather meant as singular.
What is 'auto_features' used for?
https://mesonbuild.com/Build-options.html#features
HTH,
Thomas
