Hi, Wainer, On Fri, Jul 9, 2021 at 4:32 PM Wainer dos Santos Moschetta <waine...@redhat.com> wrote: > > Hi, > > On 7/7/21 12:24 PM, Willian Rampazzo wrote: > > Although it is possible to run a specific test using the avocado > > command-line, a user may want to use a specific tag while running the > > ``make check-acceptance`` during the development or debugging. > I always wanted that feature, thanks for implementing it!
I'm glad it is helpful. > > > > This allows using the AVOCADO_TAGS environment variable where the user > > takes total control of which tests should run based on the tags defined. > > > > This also makes the check-acceptance command flexible to restrict tests > > based on tags while running on CI. > > > > e.g.: > > > > AVOCADO_TAGS="foo bar baz" make check-acceptance > > If I run `AVOCADO_TAGS="machine:malta arch:mips" make check-acceptance` > it is going to get the tests with 'machine:malta' *or* 'arch:mips' tags, > whereas with AVOCADO_TAGS="machine:malta,arch:mips" it gets those with > 'machine:malta' *and* 'arch:mips', i.e., the semantic is different. I > think it deserves a mention in the docs/devel/testing.rst, maybe linking > to Avocado's doc [1] as well. Okay, that is fair. I'll summarize something in the testing documentation and point to the Avocado doc to avoid duplication. > > [1] > https://avocado-framework.readthedocs.io/en/latest/guides/user/chapters/tags.html > > > > > Signed-off-by: Willian Rampazzo <willi...@redhat.com> > > --- > > docs/devel/testing.rst | 8 ++++++++ > > tests/Makefile.include | 12 +++++++++--- > > 2 files changed, 17 insertions(+), 3 deletions(-) > > Tested-by: Wainer dos Santos Moschetta <waine...@redhat.com> > > Reviewed-by: Wainer dos Santos Moschetta <waine...@redhat.com> > Thanks for testing and reviewing.