On 7/9/21 4:24 PM, Richard Henderson wrote: > On 7/9/21 12:08 AM, Philippe Mathieu-Daudé wrote: >> What about this one? >> >> @@ -3385,7 +3385,7 @@ static bool do_depw_sar(DisasContext *ct >> /* Convert big-endian bit numbering in SAR to left-shift. */ >> tcg_gen_xori_reg(shift, cpu_sar, TARGET_REGISTER_BITS - 1); >> >> - mask = tcg_const_reg(msb + (msb - 1)); >> + mask = tcg_constant_reg(msb + (msb - 1)); >> tcg_gen_and_reg(tmp, val, mask); >> if (rs) { >> tcg_gen_shl_reg(mask, mask, shift); > > Also used as destination, so it's an initialized temp not a constant.
Obviously... Sorry :) Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>