Re: [PATCH 1/2] target/hppa: Use tcg_constant_*

[Richard Henderson]

On 7/9/21 12:08 AM, Philippe Mathieu-Daudé wrote:

What about this one?

@@ -3385,7 +3385,7 @@ static bool do_depw_sar(DisasContext *ct
      /* Convert big-endian bit numbering in SAR to left-shift.  */
      tcg_gen_xori_reg(shift, cpu_sar, TARGET_REGISTER_BITS - 1);

-    mask = tcg_const_reg(msb + (msb - 1));
+    mask = tcg_constant_reg(msb + (msb - 1));
      tcg_gen_and_reg(tmp, val, mask);
      if (rs) {
          tcg_gen_shl_reg(mask, mask, shift);

Also used as destination, so it's an initialized temp not a constant.


r~