On 7/6/21 12:52 PM, Thomas Huth wrote: > On 21/06/2021 17.21, Alex Bennée wrote: >> From: Philippe Mathieu-Daudé <f4...@amsat.org> >> >> Add a target-specific Kconfig. We need the definitions in Kconfig so >> the minikconf tool can verify they exit. However CONFIG_FOO is only > > s/exit/exist/ ? > >> enabled for target foo via the meson.build rules. >> >> Two architecture have a particularity, ARM and MIPS: >> their 64-bit version include the 32-bit subset. > > Why do you mention these here, but not x86, Sparc, PPC and RISC-V which > also have 32-bit and 64-bit variants?
Because we consider them as different targets, they don't include (kselect) the subset. > > The patch itself looks fine to me, so once you've clarified the commit > message: > > Reviewed-by: Thomas Huth <th...@redhat.com> > > >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> Message-Id: <20210131111316.232778-6-f4...@amsat.org> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> >> >> --- >> vajb: >> - removed targets that no longer exist >> - reword commit message to show why we need the Kconfigs >> --- >> diff --git a/target/arm/Kconfig b/target/arm/Kconfig >> new file mode 100644 >> index 0000000000..3f3394a22b >> --- /dev/null >> +++ b/target/arm/Kconfig >> @@ -0,0 +1,6 @@ >> +config ARM >> + bool >> + >> +config AARCH64 >> + bool >> + select ARM >> diff --git a/target/mips/Kconfig b/target/mips/Kconfig >> new file mode 100644 >> index 0000000000..6adf145354 >> --- /dev/null >> +++ b/target/mips/Kconfig >> @@ -0,0 +1,6 @@ >> +config MIPS >> + bool >> + >> +config MIPS64 >> + bool >> + select MIPS
