ok, will swap 03 and 04 in next version.
Thanks,
AL
________________________________
From: Thomas Huth <th...@redhat.com>
Sent: Thursday, July 1, 2021 6:32 PM
To: Al Cho <a...@suse.com>; qemu-devel@nongnu.org <qemu-devel@nongnu.org>;
qemu-s3...@nongnu.org <qemu-s3...@nongnu.org>
Cc: Claudio Fontana <claudio.font...@suse.com>; José Ricardo Ziviani
<jose.zivi...@suse.com>; Claudio Fontana <cfont...@suse.de>; David Hildenbrand
<da...@redhat.com>; Cornelia Huck <coh...@redhat.com>
Subject: Re: [RFC v6 04/13] hw/s390x: tod: make explicit checks for
accelerators when initializing
On 29/06/2021 16.19, Cho, Yu-Chen wrote:
> replace general "else" with specific checks for each possible accelerator.
>
> Handle qtest as a NOP, and error out for an unknown accelerator used in
> combination with tod.
>
> Signed-off-by: Claudio Fontana <cfont...@suse.de>
> Reviewed-by: David Hildenbrand <da...@redhat.com>
> Reviewed-by: Cornelia Huck <coh...@redhat.com>
> Signed-off-by: Cho, Yu-Chen <a...@suse.com>
> ---
> hw/s390x/tod.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/tod.c b/hw/s390x/tod.c
> index 3c2979175e..fd5a36bf24 100644
> --- a/hw/s390x/tod.c
> +++ b/hw/s390x/tod.c
> @@ -14,6 +14,8 @@
> #include "qemu/error-report.h"
> #include "qemu/module.h"
> #include "sysemu/kvm.h"
> +#include "sysemu/tcg.h"
> +#include "sysemu/qtest.h"
> #include "migration/qemu-file-types.h"
> #include "migration/register.h"
>
> @@ -23,8 +25,13 @@ void s390_init_tod(void)
>
> if (kvm_enabled()) {
> obj = object_new(TYPE_KVM_S390_TOD);
> - } else {
> + } else if (tcg_enabled()) {
> obj = object_new(TYPE_QEMU_S390_TOD);
> + } else if (qtest_enabled()) {
> + return;
> + } else {
> + error_report("current accelerator not handled in s390_init_tod!");
> + abort();
> }
> object_property_add_child(qdev_get_machine(), TYPE_S390_TOD, obj);
> object_unref(obj);
>
I think it might be better to swap the order of patch 03 and 04, to avoid
that the qtests might break during bisecting later.
For this patch itself:
Reviewed-by: Thomas Huth <th...@redhat.com>
