Thanks Gerd. I will submit another patch using PRId64 In warn_report. Regards, SweeAun
-----Original Message----- From: Gerd Hoffmann <kra...@redhat.com> Sent: Thursday, June 24, 2021 4:49 PM To: Khor, Swee Aun <swee.aun.k...@intel.com> Cc: qemu-devel@nongnu.org; arm...@redhat.com; ebl...@redhat.com; Romli, Khairul Anuar <khairul.anuar.ro...@intel.com>; Kasireddy, Vivek <vivek.kasire...@intel.com>; Mazlan, Hazwan Arif <hazwan.arif.maz...@intel.com> Subject: Re: [PATCH v3] ui/gtk: New -display gtk option 'full-screen-on-monitor'. On Thu, Jun 24, 2021 at 12:56:28AM +0000, Khor, Swee Aun wrote: > Hi Gerd, > I am able to compile the code without error with my v3 patch. I don't see my > patch showing up in https://patchew.org/QEMU/ , is it due to this compilation > error? > > I tried to change from %ld -> %lld but I encountered compilation error this > time. > > ../ui/gtk.c: In function 'gtk_display_init': > ../ui/gtk.c:2300:25: error: format '%lld' expects argument of type 'long long > int', but argument 2 has type 'int64_t' {aka 'long int'} [-Werror=format=] > 2300 | warn_report("Failed to enable full screen on monitor > %lld. " > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ...... > 2303 | opts->u.gtk.full_screen_on_monitor, > monitor_n); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | > | int64_t {aka long int} > cc1: all warnings being treated as errors stdint.h also has #defines for printing integers (PRI{x,d}{8,16,32,64}), they make sure the correct format string is used. PRId64 would be the one for int64_t take care, Gerd
