Hi Gerd, I am able to compile the code without error with my v3 patch. I don't see my patch showing up in https://patchew.org/QEMU/ , is it due to this compilation error?
I tried to change from %ld -> %lld but I encountered compilation error this time. ../ui/gtk.c: In function 'gtk_display_init': ../ui/gtk.c:2300:25: error: format '%lld' expects argument of type 'long long int', but argument 2 has type 'int64_t' {aka 'long int'} [-Werror=format=] 2300 | warn_report("Failed to enable full screen on monitor %lld. " | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...... 2303 | opts->u.gtk.full_screen_on_monitor, monitor_n); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | int64_t {aka long int} cc1: all warnings being treated as errors Suspect it is due to variants of host machine, I think I will change it to use PRId64 which is more generic for all platform like below. What you think? warn_report("Failed to enable full screen on monitor %" PRId64 ". " "Current total number of monitors is %d, " "please verify full-screen-on-monitor option value.", opts->u.gtk.full_screen_on_monitor, monitor_n); or you prefer casting ? This seems working as well. warn_report("Failed to enable full screen on monitor %lld . " "Current total number of monitors is %d, " "please verify full-screen-on-monitor option value.", (long long)opts->u.gtk.full_screen_on_monitor, monitor_n); Regards, SweeAun -----Original Message----- From: Gerd Hoffmann <kra...@redhat.com> Sent: Wednesday, June 23, 2021 8:34 PM To: Khor, Swee Aun <swee.aun.k...@intel.com> Cc: qemu-devel@nongnu.org; arm...@redhat.com; ebl...@redhat.com; Romli, Khairul Anuar <khairul.anuar.ro...@intel.com>; Kasireddy, Vivek <vivek.kasire...@intel.com>; Mazlan, Hazwan Arif <hazwan.arif.maz...@intel.com>; k...@sirius.home.kraxel.org Subject: Re: [PATCH v3] ui/gtk: New -display gtk option 'full-screen-on-monitor'. On Wed, Jun 23, 2021 at 04:27:44PM +0800, Khor, Swee Aun wrote: > This lets user select monitor number to display QEMU in full screen > with -display gtk,full-screen-on-monitor=<value>. ../../ui/gtk.c: In function 'gtk_display_init': ../../ui/gtk.c:2300:25: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'int64_t' {aka 'long long int'} [-Werror=format=] 2300 | warn_report("Failed to enable full screen on monitor %ld. " | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...... 2303 | opts->u.gtk.full_screen_on_monitor, monitor_n); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | int64_t {aka long long int} take care, Gerd