On 2/10/21 12:54 PM, Philippe Mathieu-Daudé wrote: > On 2/4/21 11:37 PM, Hao Wu wrote: >> I don't see this error. It could be some error in the clock that the >> timer module does not get a correct clock input. >> How do you reproduce this? > > I got it only once, can not reproduce, but it happened on our CI too: > https://gitlab.com/qemu-project/qemu/-/jobs/1006073367#L4430
Again earlier today: https://gitlab.com/qemu-project/qemu/-/jobs/1364690563#L3996 ERROR:../tests/qtest/npcm7xx_timer-test.c:475:test_periodic_interrupt: assertion failed (tim_read(td, TISR) == tim_timer_bit(td)): (0x00000000 == 0x00000010) ** ERROR:../tests/qtest/npcm7xx_timer-test.c:476:test_periodic_interrupt: 'qtest_get_irq(global_qtest, tim_timer_irq(td))' should be TRUE FAIL 179 qtest-arm/npcm7xx_timer-test /arm/npcm7xx_timer/tim[2]/timer[4]/periodic_interrupt > >> >> On Thu, Feb 4, 2021 at 1:39 AM Philippe Mathieu-Daudé <f4...@amsat.org >> <mailto:f4...@amsat.org>> wrote: >> >> Hi, >> >> On Tue, Jan 12, 2021 at 6:20 PM Peter Maydell >> <peter.mayd...@linaro.org <mailto:peter.mayd...@linaro.org>> >> wrote: >> > >> > From: Hao Wu <wuhao...@google.com <mailto:wuhao...@google.com>> >> > >> > This patch makes NPCM7XX Timer to use a the timer clock generated >> by the >> > CLK module instead of the magic number TIMER_REF_HZ. >> > >> > Reviewed-by: Havard Skinnemoen <hskinnem...@google.com >> <mailto:hskinnem...@google.com>> >> > Reviewed-by: Tyrone Ting <kft...@nuvoton.com >> <mailto:kft...@nuvoton.com>> >> > Signed-off-by: Hao Wu <wuhao...@google.com >> <mailto:wuhao...@google.com>> >> > Message-id: 20210108190945.949196-3-wuhao...@google.com >> <mailto:20210108190945.949196-3-wuhao...@google.com> >> > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org >> <mailto:peter.mayd...@linaro.org>> >> > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org >> <mailto:peter.mayd...@linaro.org>> >> > --- >> > include/hw/misc/npcm7xx_clk.h | 6 ----- >> > include/hw/timer/npcm7xx_timer.h | 1 + >> > hw/arm/npcm7xx.c | 5 ++++ >> > hw/timer/npcm7xx_timer.c | 39 >> +++++++++++++++----------------- >> > 4 files changed, 24 insertions(+), 27 deletions(-) >> >> Is that a spurious error (building with Clang)? >> >> Running test qtest-arm/npcm7xx_timer-test >> ERROR:../tests/qtest/npcm7xx_timer-test.c:475:test_periodic_interrupt: >> assertion failed (tim_read(td, TISR) == tim_timer_bit(td)): (0x00000000 >> == 0x00000004) >> ERROR:../tests/qtest/npcm7xx_timer-test.c:476:test_periodic_interrupt: >> 'qtest_get_irq(global_qtest, tim_timer_irq(td))' should be TRUE >> FAIL 155 qtest-arm/npcm7xx_timer-test >> /arm/npcm7xx_timer/tim[2]/timer[2]/periodic_interrupt >> make: *** [Makefile.mtest:1033: run-test-127] Error 1 >> >
