On 6/21/21 7:01 AM, Peter Maydell wrote:
On Mon, 14 Jun 2021 at 09:41, Richard Henderson <richard.hender...@linaro.org> wrote:Signed-off-by: Richard Henderson <richard.hender...@linaro.org> --- tcg/aarch64/tcg-target.c.inc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc index 27cde314a9..f72218b036 100644 --- a/tcg/aarch64/tcg-target.c.inc +++ b/tcg/aarch64/tcg-target.c.inc @@ -2187,12 +2187,24 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, tcg_out_rev64(s, a0, a1); break; case INDEX_op_bswap32_i64: + tcg_out_rev32(s, a0, a1); + if (a2 & TCG_BSWAP_OS) { + tcg_out_sxt(s, TCG_TYPE_I64, MO_32, a0, a0); + }Side note: it's rather confusing that tcg_out_rev32() doesn't emit a REV32 insn (it emits REV with sf==0).
Mm, yes. I'll tidy that up in a separate patch. r~
