On 6/17/21 11:33 AM, Daniel P. Berrangé wrote: > On Wed, Jun 16, 2021 at 09:21:45PM +0200, Philippe Mathieu-Daudé wrote: >> On 6/16/21 9:12 PM, Richard Henderson wrote: >>> On 6/16/21 9:22 AM, Philippe Mathieu-Daudé wrote: >>>> Introduce the qcrypto_tls_creds_check_endpoint() helper >>>> to avoid accessing QCryptoTLSCreds internal 'endpoint' field >>>> directly. >>> >>> I don't understand this one. Comment ... >>> >>>> +bool qcrypto_tls_session_check_role(QCryptoTLSCreds *creds, >>>> + QCryptoTLSCredsEndpoint endpoint, >>>> + Error **errp) >>>> +{ >>>> + return qcrypto_tls_creds_check_endpoint(creds, endpoint, errp); >>>> +} >>> >>> ... doesn't match the function. >>> >>> The new function is a pure forwarder, and begs the question of why the >>> caller isn't using qcrypto_tls_creds_check_endpoint directly. >> >> I tried to follow the maintainer/subsystem style (I was also tempted to >> use qcrypto_tls_creds_check_endpoint directly). ui/vnc uses the TLS >> "session" API and not the "creds" one. Daniel, what is your preference? > > I think we don't need this extra function - just use the function from > earlier directly.
Great, simpler :)