On 6/2/21 4:41 PM, Patrick Venture wrote: > On Thu, May 27, 2021 at 2:34 AM Peter Maydell <peter.mayd...@linaro.org> > wrote: >> >> On Tue, 18 May 2021 at 20:54, Patrick Venture <vent...@google.com> wrote: >>> >>> Adds initial quanta-gbs-bmc machine support. >>> >>> Tested: Boots to userspace. >>> Signed-off-by: Patrick Venture <vent...@google.com> >>> Reviewed-by: Brandon Kim <brandon...@google.com> >>> Reviewed-by: Hao Wu <wuhao...@google.com> >>> --- >>> hw/arm/npcm7xx_boards.c | 33 +++++++++++++++++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> >>> diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c >>> index d4553e3786..34a214fe79 100644 >>> --- a/hw/arm/npcm7xx_boards.c >>> +++ b/hw/arm/npcm7xx_boards.c >>> @@ -29,6 +29,7 @@ >>> >>> #define NPCM750_EVB_POWER_ON_STRAPS 0x00001ff7 >>> #define QUANTA_GSJ_POWER_ON_STRAPS 0x00001fff >>> +#define QUANTA_GBS_POWER_ON_STRAPS 0x000017ff /* TODO: Get real values. */ >> >> Any chance you could fix this TODO ? If it's not fixed now before >> the code goes in it seems unlikely that it'll ever be fixed -- you're >> probably in the best position to know the right value... > > I have an internal bug to find the "right" value and populate it, > although it probably actually is that value.
Then simply remove the TODO comment and we are good :)
