John Snow <js...@redhat.com> writes: > On 4/27/21 3:00 AM, Markus Armbruster wrote: >> John Snow <js...@redhat.com> writes: >> >>> On 4/25/21 3:59 AM, Markus Armbruster wrote:
[...] >> Please add test cases. I recommend adding them in a separate patch, so >> this one's diff shows clearly what's being fixed. >> > > Can't, again: because it's a crash, the test runner explodes. > > Two choices, because I won't finish respinning this tonight: > > (1) Amend the test runner to print generic exceptions using str(err), > without the stack trace -- so we can check for crashes using the diffs > -- again in its own commit. > > (2) Just squish the tests and error messages into this commit like I did > for the other crash fix I checked in. > > I'd normally leap for #1, but you seem to have some affinity for > allowing unpredictable things to explode very violently, so I am not sure. I love violent explosions. Don't we all, as long as they're just bits? (2) is fine. If you'd like to provide for committing tests that currently explode: the issue preventing it is insufficiently normalized output of test-qapi.py. test-qapi.py normalizes error messages (see except QAPIError in test_and_diff()), but not tracebacks. Omitting the tracebacks is an obvious and easy way to normalize. But it makes getting at the traceback harder: I need to know / remember how to run the test by hand, without the normalization. The cure seems worse than the disease here. To avoid the drawback, we'd need a simple and obvious way to run the test so it shows the traceback. Again, (2) is fine.
