On 3/26/21 2:34 PM, Peter Maydell wrote: > ping for review? FYI: https://www.mail-archive.com/qemu-devel@nongnu.org/msg790977.html
> On Fri, 19 Mar 2021 at 16:24, Peter Maydell <peter.mayd...@linaro.org> wrote: >> >> In commit 81b3ddaf8772ec we fixed a use of uninitialized data >> in read_tcnt(). However this change wasn't enough to placate >> Coverity, which is not smart enough to see that if we read a >> 2 bit field and then handle cases 0, 1, 2 and 3 then there cannot >> be a flow of execution through the switch default. Add explicit >> default cases which assert that they can't be reached, which >> should help silence Coverity. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> hw/timer/renesas_tmr.c | 4 ++++ >> 1 file changed, 4 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>