Oh, I understand what you mean, and will change it in V3. Thanks, Lei.
-----Original Message----- From: lizhij...@fujitsu.com <lizhij...@fujitsu.com> Sent: Friday, March 12, 2021 6:23 PM To: Rao, Lei <lei....@intel.com>; Zhang, Chen <chen.zh...@intel.com>; jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com; pbonz...@redhat.com; lukasstra...@web.de Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v2 05/10] Optimize the function of packet_new > + offset = colo_bitmap_find_dirty(ram_state, block, offset, > + &num); IIUC, this return value would pass to the next round as start index, so you should skip the already checked one. Thanks On 3/12/21 5:56 PM, Rao, Lei wrote: > How about redefine a function named packet_new_nocopy? > In comments, we can tell the caller don't release the buffer and the > packet_destroy will release it. > > Thanks, > Lei. > -----Original Message----- > From:lizhij...@fujitsu.com <lizhij...@fujitsu.com> > Sent: Friday, March 12, 2021 2:53 PM > To: Rao, Lei<lei....@intel.com>; Zhang, > Chen<chen.zh...@intel.com>;jasow...@redhat.com;quint...@redhat.com;dgi > lb...@redhat.com;pbonz...@redhat.com;lukasstra...@web.de > Cc:qemu-devel@nongnu.org > Subject: Re: [PATCH v2 05/10] Optimize the function of packet_new > >
