On Fri, Feb 19, 2021 at 11:50:54AM +0000, Luis Henriques wrote: > Vivek Goyal <vgo...@redhat.com> writes: > > > Hi, > > > > This is V2 of the patches. Changes since v1 are. > > > > - Rebased on top of latest master. > > - Took care of Miklos's comments to block acl xattrs if user > > explicitly disabled posix acl. > > > > Luis Henriques reported that fstest generic/099 fails with virtiofs. > > Little debugging showed that we don't enable acl support. So this > > patch series provides option to enable/disable posix acl support. By > > default it is disabled. > > > > I have run blogbench and pjdfstests with posix acl enabled and > > things work fine. > > > > Luis, can you please apply these patches, and run virtiofsd with > > "-o posix_acl" and see if it fixes the failure you are seeing. I > > ran the steps you provided manually and it fixes the issue for > > me. > > Sorry for the delay. I've finally tested these patches and they indeed > fix the problem I reported. My only question about this fix is why is > this option not enabled by default, since this is the documented behavior > in acl(5) and umask(2)? In fact, why is this an option at all?
Ah! An obvious thing that's missing: change tools/virtiofsd/helper.c to include the new option (and also the manpage) ;-) Cheers, -- Luís
