On 09/14/2011 06:27 PM, Richard Henderson wrote:
On 09/14/2011 08:23 AM, Avi Kivity wrote: > On 09/14/2011 06:10 PM, Richard Henderson wrote: >> > >> > So the default address passed to the handler is now already relative? I >> > think we should keep it like this for all converted devices, ie. take >> > the chance, fix the remaining models, and drop the offset. >> >> It's non-zero for the isa portio conversion that I did, which >> I thought was in Avi's tree. > > That's MemoryRegionPortio::offset, not MemoryRegion::offset.No, look in isa_register_portio_list: memory_region_init_io(region, ops, opaque, name, off_high - off_low); memory_region_set_offset(region, start + off_low); That last line sets MemoryRegion::offset.
That's not in my queue. Which patchset was that? -- error compiling committee.c: too many arguments to function
