On Wed, Feb 10, 2021 at 06:10:13PM +0800, Bin Meng wrote: > From: Xuzhou Cheng <xuzhou.ch...@windriver.com> > > Now that the XLNX CSU DMA model is implemented, the existing codes > in the ZynqMP QSPIS are useless and should be removed.
We should also modify XLNX_ZYNQMP_SPIPS_R_MAX in the header file. Otherwise, this looks good to me. > > Signed-off-by: Xuzhou Cheng <xuzhou.ch...@windriver.com> > Signed-off-by: Bin Meng <bin.m...@windriver.com> > > --- > > Changes in v3: > - new patch: xilinx_spips: Remove DMA related code from zynqmp_qspips > > hw/ssi/xilinx_spips.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c > index 8a0cc22..1e9dba2 100644 > --- a/hw/ssi/xilinx_spips.c > +++ b/hw/ssi/xilinx_spips.c > @@ -195,13 +195,6 @@ > #define R_GQSPI_MOD_ID (0x1fc / 4) > #define R_GQSPI_MOD_ID_RESET (0x10a0000) > > -#define R_QSPIDMA_DST_CTRL (0x80c / 4) > -#define R_QSPIDMA_DST_CTRL_RESET (0x803ffa00) > -#define R_QSPIDMA_DST_I_MASK (0x820 / 4) > -#define R_QSPIDMA_DST_I_MASK_RESET (0xfe) > -#define R_QSPIDMA_DST_CTRL2 (0x824 / 4) > -#define R_QSPIDMA_DST_CTRL2_RESET (0x081bfff8) > - > /* size of TXRX FIFOs */ > #define RXFF_A (128) > #define TXFF_A (128) > @@ -417,9 +410,6 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d) > s->regs[R_GQSPI_GPIO] = 1; > s->regs[R_GQSPI_LPBK_DLY_ADJ] = R_GQSPI_LPBK_DLY_ADJ_RESET; > s->regs[R_GQSPI_MOD_ID] = R_GQSPI_MOD_ID_RESET; > - s->regs[R_QSPIDMA_DST_CTRL] = R_QSPIDMA_DST_CTRL_RESET; > - s->regs[R_QSPIDMA_DST_I_MASK] = R_QSPIDMA_DST_I_MASK_RESET; > - s->regs[R_QSPIDMA_DST_CTRL2] = R_QSPIDMA_DST_CTRL2_RESET; > s->man_start_com_g = false; > s->gqspi_irqline = 0; > xlnx_zynqmp_qspips_update_ixr(s); > -- > 2.7.4 >
