On 2/10/21 12:12 PM, Philippe Mathieu-Daudé wrote: > Hi Bin, > > On 2/10/21 11:23 AM, Bin Meng wrote: >> From: Bin Meng <bin.m...@windriver.com> >> >> Current QEMU HEAD nvme.c does not compile: >> >> hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this >> function [-Werror=maybe-uninitialized] >> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled"); >> ^ >> hw/block/nvme.c:3150:14: note: ‘result’ was declared here >> uint32_t result; >> ^ > > Why isn't this catched by our CI? What is your host OS? Fedora 33?
Just noticed v1 and Peter's explanation: https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03528.html Can you amend "default GCC 5.4 on a Ubuntu 16.04 host" information please? > >> >> Explicitly initialize the result to fix it. >> >> Fixes: aa5e55e3b07e ("hw/block/nvme: open code for volatile write cache") >> Signed-off-by: Bin Meng <bin.m...@windriver.com> >> >> --- >> >> Changes in v2: >> - update function name in the commit message >> >> hw/block/nvme.c | 1 + >> 1 file changed, 1 insertion(+)
