On Mon, Feb 8, 2021 at 3:09 AM Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
> Hi Doug, > > On 2/3/21 10:37 PM, dje--- via wrote: > > ... in preparation for adding ipv6 host forwarding support. > > Please duplicate subject line, else this commit description as it > doesn't make sense. > Hmmm. Is this a bug in git format-patch/send-email? I agree the current behaviour is suboptimal ... Perhaps there's an option I'm not adding? Or does one manually work around this? > --- > > net/slirp.c | 200 +++++++++++++++++++++++++++++++++------------------- > > slirp | 2 +- > > 2 files changed, 130 insertions(+), 72 deletions(-) > > > ... > > > diff --git a/slirp b/slirp > > index 8f43a99191..358c0827d4 160000 > > --- a/slirp > > +++ b/slirp > > @@ -1 +1 @@ > > -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece > > +Subproject commit 358c0827d49778f016312bfb4167fe639900681f > > > > When updating submodules, please describe changes (usually - > when possible - a previous commit updating the submodule is > preferred). > > I can not apply your patch using either > https://git.qemu.org/git/libslirp.git or > https://gitlab.freedesktop.org/slirp/libslirp.git: > > fatal: bad object 358c0827d49778f016312bfb4167fe639900681f > I think that's expected until the patch has been merged from libslirp into qemu 's tree. Samuel, how do qemu patches involving libslirp changes usually work? Should I have held off submitting the qemu patch until the libslirp prerequisite has been added to qemu's tree, or maybe I should include the libslirp patch so that people can at least apply it (with a caveat saying the patch is already in libslirp.git) until it's added to the qemu tree?
