On Sun, Feb 07, 2021 at 08:23:33PM +0200, Marian Postevca wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > > > > > I queued this but there's a lot of code duplication with this. > > Further, the use of g_strdup adds unnecessary dynamic memory > > management where it's not needed. > > I'd prefer > > - a new struct AcpiBuildOem including the correct strings > > - use sizeof of fields in above instead of 8/6 > > - move shared strings and code into a common header > > > > So how should I approach this since the patches are queued? A new patch > with the suggested changes, or resending the original patches?
A patch on top please. They are merged so really easy, just basing on masted should be good. -- MST
