Re: [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate.

[Rebecca Cran]

On 1/22/21 2:03 PM, Richard Henderson wrote:
On 1/21/21 6:45 PM, Rebecca Cran wrote:

          cpsr_write(env, spsr, mask, CPSRWriteRaw);
-        if (!arm_singlestep_active(env)) {
-            env->uncached_cpsr &= ~PSTATE_SS;
-        }
+        env->pstate &= ~PSTATE_SS;

Why are you removing the singlestep check?

-    env->uncached_cpsr &= ~PSTATE_SS;
-    env->spsr = cpsr_read(env);
+    env->pstate &= ~PSTATE_SS;
+    env->spsr &= ~PSTATE_SS;

This loses the saving of cpsr into spsr.

Oh, right. I've fixed both this and the above issue in the next revision 
which I'll send out early next week (giving a chance for any extra 
feedback).

Thanks.
--
Rebecca Cran