On Fri, 8 Jan 2021 at 15:55, Bin Meng <bmeng...@gmail.com> wrote: > > On Fri, Jan 8, 2021 at 10:40 PM Peter Maydell <peter.mayd...@linaro.org> > wrote: > > Calling qemu_set_irq() in a device reset function is a bad > > idea, because you don't know whether the thing on the other > > end of the IRQ line (a) has already reset before you or > > (b) is going to reset after you. If you need to do this then > > I think you need to convert this device (and perhaps whatever > > it's connected to) to the 3-phase-reset API. (But you probably > > don't, see below.) > > > > Thanks for the review. What about the imx_spi_update_irq() in the > imx_spi_reset()? Should we remove that from the imx_spi_reset() as > well?
Yes, I think so. thanks -- PMM
