Patchew URL: https://patchew.org/QEMU/20201218025040.98132-1-...@ozlabs.ru/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201218025040.98132-1-...@ozlabs.ru Subject: [PATCH qemu v12] spapr: Implement Open Firmware client interface === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201218025040.98132-1-...@ozlabs.ru -> patchew/20201218025040.98132-1-...@ozlabs.ru Switched to a new branch 'test' 453ef2b spapr: Implement Open Firmware client interface === OUTPUT BEGIN === WARNING: line over 80 characters #223: FILE: hw/ppc/spapr.c:4463: + ClientArchitectureSupportClass *casc = CLIENT_ARCHITECTURE_SUPPORT_CLASS(oc); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #282: new file mode 100644 WARNING: line over 80 characters #1398: FILE: hw/ppc/vof.h:31: + INTERFACE_CHECK(ClientArchitectureSupport, (obj), TYPE_CLIENT_ARCHITECTURE_SUPPORT) ERROR: code indent should never use tabs #1514: FILE: pc-bios/vof/bootmem.c:5: +^Iuint64_t kern[2];$ ERROR: code indent should never use tabs #1515: FILE: pc-bios/vof/bootmem.c:6: +^Iphandle chosen = ci_finddevice("/chosen");$ ERROR: code indent should never use tabs #1517: FILE: pc-bios/vof/bootmem.c:8: +^Iif (ci_getprop(chosen, "qemu,boot-kernel", kern, sizeof(kern)) !=$ ERROR: code indent should never use tabs #1518: FILE: pc-bios/vof/bootmem.c:9: +^I^I^Isizeof(kern))$ ERROR: code indent should never use tabs #1519: FILE: pc-bios/vof/bootmem.c:10: +^I^Ireturn;$ ERROR: code indent should never use tabs #1521: FILE: pc-bios/vof/bootmem.c:12: +^Ido_boot(kern[0], initrd, initrdsize);$ ERROR: externs should be avoided in .c files #1540: FILE: pc-bios/vof/ci.c:12: +extern uint32_t ci_entry(uint32_t params); ERROR: externs should be avoided in .c files #1542: FILE: pc-bios/vof/ci.c:14: +extern unsigned long hv_rtas(unsigned long params); ERROR: externs should be avoided in .c files #1543: FILE: pc-bios/vof/ci.c:15: +extern unsigned int hv_rtas_size; ERROR: code indent should never use tabs #1547: FILE: pc-bios/vof/ci.c:19: +^Ivoid *rtasbase;$ ERROR: code indent should never use tabs #1548: FILE: pc-bios/vof/ci.c:20: +^Iuint32_t rtassize = 0;$ ERROR: code indent should never use tabs #1549: FILE: pc-bios/vof/ci.c:21: +^Iphandle rtas;$ ERROR: code indent should never use tabs #1551: FILE: pc-bios/vof/ci.c:23: +^Iif (strcmp("call-method", (void *)(unsigned long) pargs->service))$ ERROR: braces {} are necessary for all arms of this statement #1551: FILE: pc-bios/vof/ci.c:23: + if (strcmp("call-method", (void *)(unsigned long) pargs->service)) [...] ERROR: code indent should never use tabs #1552: FILE: pc-bios/vof/ci.c:24: +^I^Ireturn false;$ ERROR: code indent should never use tabs #1554: FILE: pc-bios/vof/ci.c:26: +^Iif (strcmp("instantiate-rtas", (void *)(unsigned long) pargs->args[0]))$ ERROR: braces {} are necessary for all arms of this statement #1554: FILE: pc-bios/vof/ci.c:26: + if (strcmp("instantiate-rtas", (void *)(unsigned long) pargs->args[0])) [...] ERROR: code indent should never use tabs #1555: FILE: pc-bios/vof/ci.c:27: +^I^Ireturn false;$ ERROR: code indent should never use tabs #1557: FILE: pc-bios/vof/ci.c:29: +^Irtas = ci_finddevice("/rtas");$ ERROR: code indent should never use tabs #1558: FILE: pc-bios/vof/ci.c:30: +^Ici_getprop(rtas, "rtas-size", &rtassize, sizeof(rtassize));$ ERROR: code indent should never use tabs #1559: FILE: pc-bios/vof/ci.c:31: +^Iif (rtassize < hv_rtas_size)$ ERROR: braces {} are necessary for all arms of this statement #1559: FILE: pc-bios/vof/ci.c:31: + if (rtassize < hv_rtas_size) [...] ERROR: code indent should never use tabs #1560: FILE: pc-bios/vof/ci.c:32: +^I^Ireturn false;$ ERROR: code indent should never use tabs #1562: FILE: pc-bios/vof/ci.c:34: +^Irtasbase = (void *)(unsigned long) pargs->args[2];$ ERROR: code indent should never use tabs #1564: FILE: pc-bios/vof/ci.c:36: +^Imemcpy(rtasbase, hv_rtas, hv_rtas_size);$ ERROR: code indent should never use tabs #1565: FILE: pc-bios/vof/ci.c:37: +^Ipargs->args[pargs->nargs] = 0;$ ERROR: code indent should never use tabs #1566: FILE: pc-bios/vof/ci.c:38: +^Ipargs->args[pargs->nargs + 1] = pargs->args[2];$ ERROR: code indent should never use tabs #1568: FILE: pc-bios/vof/ci.c:40: +^Ireturn true;$ ERROR: code indent should never use tabs #1573: FILE: pc-bios/vof/ci.c:45: +^Iif (!prom_handle((void *)(unsigned long) args))$ ERROR: braces {} are necessary for all arms of this statement #1573: FILE: pc-bios/vof/ci.c:45: + if (!prom_handle((void *)(unsigned long) args)) [...] ERROR: code indent should never use tabs #1574: FILE: pc-bios/vof/ci.c:46: +^I^Ici_entry(args);$ ERROR: braces {} are necessary for all arms of this statement #1588: FILE: pc-bios/vof/ci.c:60: + for (i = 0; i < nargs; i++) [...] ERROR: braces {} are necessary for all arms of this statement #1592: FILE: pc-bios/vof/ci.c:64: + for (i = 0; i < nret; i++) [...] ERROR: spaces required around that '+' (ctx:VxV) #1593: FILE: pc-bios/vof/ci.c:65: + args.args[nargs+i] = 0; ^ ERROR: braces {} are necessary for all arms of this statement #1595: FILE: pc-bios/vof/ci.c:67: + if (ci_entry((uint32_t)(&args)) < 0) [...] ERROR: code indent should never use tabs #1603: FILE: pc-bios/vof/ci.c:75: +^Icall_prom("exit", 0, 0);$ ERROR: code indent should never use tabs #1608: FILE: pc-bios/vof/ci.c:80: +^Ireturn call_prom("finddevice", 1, 1, path);$ ERROR: code indent should never use tabs #1613: FILE: pc-bios/vof/ci.c:85: +^Ireturn call_prom("getprop", 4, 1, ph, propname, prop, len);$ ERROR: code indent should never use tabs #1618: FILE: pc-bios/vof/ci.c:90: +^Ireturn call_prom("open", 1, 1, path);$ ERROR: code indent should never use tabs #1623: FILE: pc-bios/vof/ci.c:95: +^Icall_prom("close", 1, 0, ih);$ ERROR: code indent should never use tabs #1628: FILE: pc-bios/vof/ci.c:100: +^Iuint32_t ret = call_prom("claim", 3, 1, ADDR(virt), size, align);$ ERROR: code indent should never use tabs #1630: FILE: pc-bios/vof/ci.c:102: +^Ireturn (void *) (unsigned long) ret;$ ERROR: code indent should never use tabs #1635: FILE: pc-bios/vof/ci.c:107: +^Ireturn call_prom("release", 2, 1, ADDR(virt), size);$ ERROR: code indent should never use tabs #1758: FILE: pc-bios/vof/libc.c:5: +^Iint len = 0;$ ERROR: code indent should never use tabs #1760: FILE: pc-bios/vof/libc.c:7: +^Iwhile (*s != 0) {$ ERROR: code indent should never use tabs #1761: FILE: pc-bios/vof/libc.c:8: +^I^Ilen += 1;$ ERROR: code indent should never use tabs #1762: FILE: pc-bios/vof/libc.c:9: +^I^Is += 1;$ ERROR: code indent should never use tabs #1763: FILE: pc-bios/vof/libc.c:10: +^I}$ ERROR: code indent should never use tabs #1765: FILE: pc-bios/vof/libc.c:12: +^Ireturn len;$ ERROR: braces {} are necessary for all arms of this statement #1771: FILE: pc-bios/vof/libc.c:18: + if (*s1 != *s2) [...] ERROR: braces {} are necessary for all arms of this statement #1799: FILE: pc-bios/vof/libc.c:46: + if (*p1 != *p2) [...] ERROR: return is not a function, parentheses are not required #1800: FILE: pc-bios/vof/libc.c:47: + return (*p1 - *p2); ERROR: else should follow close brace '}' #1823: FILE: pc-bios/vof/libc.c:70: + } + else { ERROR: code indent should never use tabs #1856: FILE: pc-bios/vof/main.c:6: +^Iregister unsigned long r3 __asm__("r3") = _r3;$ ERROR: code indent should never use tabs #1857: FILE: pc-bios/vof/main.c:7: +^Iregister unsigned long r4 __asm__("r4") = _r4;$ ERROR: code indent should never use tabs #1858: FILE: pc-bios/vof/main.c:8: +^Iregister unsigned long r5 __asm__("r5") = (unsigned long) _prom_entry;$ ERROR: code indent should never use tabs #1860: FILE: pc-bios/vof/main.c:10: +^I((client *)(uint32_t)addr)();$ ERROR: code indent should never use tabs #1865: FILE: pc-bios/vof/main.c:15: +^Iregister unsigned long r3 __asm__("r3");$ ERROR: code indent should never use tabs #1866: FILE: pc-bios/vof/main.c:16: +^Iregister unsigned long r4 __asm__("r4");$ ERROR: code indent should never use tabs #1867: FILE: pc-bios/vof/main.c:17: +^Iregister unsigned long r5 __asm__("r5");$ ERROR: code indent should never use tabs #1868: FILE: pc-bios/vof/main.c:18: +^Iuint64_t initrd = r3, initrdsize = r4;$ ERROR: code indent should never use tabs #1870: FILE: pc-bios/vof/main.c:20: +^Iboot_from_memory(initrd, initrdsize);$ ERROR: code indent should never use tabs #1871: FILE: pc-bios/vof/main.c:21: +^Ici_panic("*** No boot target ***\n");$ total: 63 errors, 3 warnings, 1743 lines checked Commit 453ef2bd01c6 (spapr: Implement Open Firmware client interface) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201218025040.98132-1-...@ozlabs.ru/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
