On Mon, Dec 14, 2020 at 03:55:30PM +0100, Igor Mammedov wrote: > On Fri, 11 Dec 2020 17:05:20 -0500 > Eduardo Habkost <ehabk...@redhat.com> wrote: > > > Every single qdev property setter function manually checks > > dev->realized. We can just check dev->realized inside > > qdev_property_set() instead. > > > > The check is being added as a separate function > > (qdev_prop_allow_set()) because it will become a callback later. > > is callback added within this series? > and I'd add here what's the purpose of it.
It will be added in part 2 of the series. See v3: https://lore.kernel.org/qemu-devel/20201112214350.872250-35-ehabk...@redhat.com/ I don't know what else I could say about its purpose, in addition to what I wrote above, and the comment below[1]. If you are just curious about the callback and confused because it is not anywhere in this series, I can just remove the paragraph above from the commit message. Would that be enough? > [...] > > +/* returns: true if property is allowed to be set, false otherwise */ [1] ^^^ > > +static bool qdev_prop_allow_set(Object *obj, const char *name, > > + Error **errp) > > +{ > > + DeviceState *dev = DEVICE(obj); > > + > > + if (dev->realized) { > > + qdev_prop_set_after_realize(dev, name, errp); > > + return false; > > + } > > + return true; > > +} > > + -- Eduardo
