On 12/11/20 9:24 AM, Thomas Huth wrote: > To be able to compile this file with -Werror=implicit-fallthrough, > we need to add some fallthrough annotations to the case statements > that might fall through. Unfortunately, the typical "/* fallthrough */" > comments do not work here as expected since some case labels are > wrapped in macros and the compiler fails to match the comments in > this case. But using __attribute__((fallthrough)) seems to work fine, > so let's use that instead (by introducing a new QEMU_FALLTHROUGH > macro in our compiler.h header file). > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > include/qemu/compiler.h | 11 +++++++++++ > tcg/optimize.c | 4 ++++ > 2 files changed, 15 insertions(+)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~