On Fri, 11 Dec 2020 at 15:24, Thomas Huth <th...@redhat.com> wrote: > > Coverity always complains about switch-case statements that fall through > the next one when there is no comment in between - which could indicate > a forgotten "break" statement. Instead of handling these issues after > they have been committed, it would be better to avoid them in the build > process already. Thus let's enable the -Wimplicit-fallthrough warning now. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index 18c26e0389..dc2bc3c2f0 100755 > --- a/configure > +++ b/configure > @@ -2007,6 +2007,7 @@ add_to warn_flags -Wempty-body > add_to warn_flags -Wnested-externs > add_to warn_flags -Wendif-labels > add_to warn_flags -Wexpansion-to-defined > +add_to warn_flags -Wimplicit-fallthrough=2
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Maybe mention in the commit message why =2 is our preference ? thanks -- PMM
