Hi Peter, > -----Original Message----- > From: Peter Maydell <peter.mayd...@linaro.org> > Sent: Tuesday, December 1, 2020 4:53 PM > To: Sai Pavan Boddu <saip...@xilinx.com> > Cc: Markus Armbruster <arm...@redhat.com>; Marc-André Lureau > <marcandre.lur...@redhat.com>; Paolo Bonzini <pbonz...@redhat.com>; > Gerd Hoffmann <kra...@redhat.com>; Edgar Iglesias <edg...@xilinx.com>; > Francisco Eduardo Iglesias <figle...@xilinx.com>; Alistair Francis > <alistair.fran...@wdc.com>; Eduardo Habkost <ehabk...@redhat.com>; Ying > Fang <fangyi...@huawei.com>; Philippe Mathieu-Daudé > <phi...@redhat.com>; Vikram Garhwal <f...@xilinx.com>; Paul Zimmerman > <pauld...@gmail.com>; Sai Pavan Boddu <saip...@xilinx.com>; QEMU > Developers <qemu-devel@nongnu.org> > Subject: Re: [PATCH v14 1/4] usb: Add versal-usb2-ctrl-regs module > > On Tue, 1 Dec 2020 at 08:34, Sai Pavan Boddu <sai.pavan.bo...@xilinx.com> > wrote: > > > > This module emulates control registers of versal usb2 controller, this > > is added just to make guest happy. In general this module would > > control the phy-reset signal from usb controller, data coherency of > > the transactions, signals the host system errors received from controller. > > > > Signed-off-by: Sai Pavan Boddu <sai.pavan.bo...@xilinx.com> > > Signed-off-by: Vikram Garhwal <fnu.vik...@xilinx.com> > > Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > > --- > > hw/usb/meson.build | 1 + > > hw/usb/xlnx-versal-usb2-ctrl-regs.c | 229 > ++++++++++++++++++++++++++++ > > include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 45 ++++++ > > 3 files changed, 275 insertions(+) > > create mode 100644 hw/usb/xlnx-versal-usb2-ctrl-regs.c > > create mode 100644 include/hw/usb/xlnx-versal-usb2-ctrl-regs.h > > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> [Sai Pavan Boddu] Thanks for the review.
Regards, Sai Pavan > > thanks > -- PMM
