Hi Peter,
> -----Original Message-----
> From: Peter Maydell <peter.mayd...@linaro.org>
> Sent: Tuesday, December 1, 2020 4:56 PM
> To: Sai Pavan Boddu <saip...@xilinx.com>
> Cc: Markus Armbruster <arm...@redhat.com>; Marc-André Lureau
> <marcandre.lur...@redhat.com>; Paolo Bonzini <pbonz...@redhat.com>;
> Gerd Hoffmann <kra...@redhat.com>; Edgar Iglesias <edg...@xilinx.com>;
> Francisco Eduardo Iglesias <figle...@xilinx.com>; Alistair Francis
> <alistair.fran...@wdc.com>; Eduardo Habkost <ehabk...@redhat.com>; Ying
> Fang <fangyi...@huawei.com>; Philippe Mathieu-Daudé
> <phi...@redhat.com>; Vikram Garhwal <f...@xilinx.com>; Paul Zimmerman
> <pauld...@gmail.com>; Sai Pavan Boddu <saip...@xilinx.com>; QEMU
> Developers <qemu-devel@nongnu.org>
> Subject: Re: [PATCH v14 2/4] usb: Add DWC3 model
>
> On Tue, 1 Dec 2020 at 08:34, Sai Pavan Boddu <sai.pavan.bo...@xilinx.com>
> wrote:
> >
> > From: Vikram Garhwal <fnu.vik...@xilinx.com>
> >
> > This patch adds skeleton model of dwc3 usb controller attached to
> > xhci-sysbus device. It defines global register space of DWC3
> > controller, global registers control the AXI/AHB interfaces
> > properties, external FIFO support and event count support. All of
> > which are unimplemented at present,we are only supporting core reset and
> read of ID register.
> >
> > Signed-off-by: Vikram Garhwal <fnu.vik...@xilinx.com>
> > Signed-off-by: Sai Pavan Boddu <sai.pavan.bo...@xilinx.com>
> > Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com>
> > ---
>
>
> > +typedef struct USBDWC3 {
> > + SysBusDevice parent_obj;
> > + MemoryRegion iomem;
> > + MemoryRegion fifos;
> > + XHCISysbusState sysbus_xhci;
> > +
> > + uint32_t regs[USB_DWC3_R_MAX];
> > + RegisterInfo regs_info[USB_DWC3_R_MAX];
>
> This device has state but is missing the VMState struct support for migration.
> Otherwise it looks OK.
[Sai Pavan Boddu] Ok, I will fix this in V15
Thanks,
Sai Pavan
>
> thanks
> -- PMM
