On Sun, Aug 28, 2011 at 10:08 PM, Blue Swirl <blauwir...@gmail.com> wrote: > On Sun, Aug 28, 2011 at 6:13 PM, Lluís <xscr...@gmx.net> wrote: >> Blue Swirl writes: >> >>> On Sat, Aug 27, 2011 at 5:56 PM, Lluís <xscr...@gmx.net> wrote: >>>>>> I sent a patch that should fix it for everybody linking with the tracing >>>>>> objects: >>>>>> >>>>>> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03150.html >>>> >>>>> With your patch, there are warnings from linker: >>>>> ../qemu-timer-common.o: warning: multiple common of `use_rt_clock' >>>>> ../qemu-timer-common.o: warning: previous common is here >>>> >>>> Ah, yes. These extra errors are fixed by the duplicate elimination patch >>>> :) >>>> >>>> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02987.html >>>> >>>> So, you need both to keep it clean. >> >>> Using the sort function looks hackish to me. Maybe the linkage should >>> be controlled by configure instead? >> >> What do you mean? Moving the logic for selecting the object files to >> link with on each top-level target out into the configure? > > Add CONFIG_QEMU_TIMER, configure sets it to 'y' when it is needed by > simpletrace or other cases.
The $(sort) approach is simpler because it is implicit. I'm not sure that explicitly managing these dependencies is necessary. But the configure approach works for me too. Blue: Are you going to post the CONFIG_QEMU_TIMER patch? Stefan
