Blue Swirl writes: > On Fri, Aug 26, 2011 at 7:12 PM, Lluís <xscr...@gmx.net> wrote: >> Blue Swirl writes: >> >>> 957f1f99f263d57612807a9535f75ca4473f05f0 didn't consider >>> that qemu-timer-common.o is needed by simpletrace. >> >>> Fix by adding it to qga object list. >> >>> Signed-off-by: Blue Swirl <blauwir...@gmail.com> >>> --- >>> Makefile.objs | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >> >>> diff --git a/Makefile.objs b/Makefile.objs >>> index d1f3e5d..df11aec 100644 >>> --- a/Makefile.objs >>> +++ b/Makefile.objs >>> @@ -404,6 +404,9 @@ qga-obj-y = $(addprefix qga/, $(qga-nested-y)) >>> qga-obj-y += qemu-ga.o qemu-tool.o qemu-error.o qemu-sockets.o >>> module.o qemu-option.o cutils.o osdep.o >>> qga-obj-$(CONFIG_WIN32) += oslib-win32.o >>> qga-obj-$(CONFIG_POSIX) += oslib-posix.o >>> +ifeq ($(TRACE_BACKEND),simple) >>> +qga-obj-y += qemu-timer-common.o >>> +endif >> >>> vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS) >> >> I sent a patch that should fix it for everybody linking with the tracing >> objects: >> >> http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03150.html
> With your patch, there are warnings from linker: > ../qemu-timer-common.o: warning: multiple common of `use_rt_clock' > ../qemu-timer-common.o: warning: previous common is here Ah, yes. These extra errors are fixed by the duplicate elimination patch :) http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02987.html So, you need both to keep it clean. Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth
