Re: [PATCH 03/16] util/vfio-helpers: Pass minimum page size to qemu_vfio_open_pci()

[Philippe Mathieu-Daudé]

On 10/22/20 4:00 PM, Stefan Hajnoczi wrote:

On Tue, Oct 20, 2020 at 07:24:15PM +0200, Philippe Mathieu-Daudé wrote:

@@ -724,7 +725,7 @@ static int nvme_init(BlockDriverState *bs, const char 
*device, int namespace,
          goto out;
      }

- s->page_size = MAX(4096, 1u << (12 + NVME_CAP_MPSMIN(cap)));

+    s->page_size = MAX(min_page_size, 1u << (12 + NVME_CAP_MPSMIN(cap)));

Is there a guarantee that the NVMe drive supports our min_page_size?

No, good point!

Stefan