On Donnerstag, 8. Oktober 2020 15:52:08 CEST Paolo Bonzini wrote: > On 08/10/20 15:42, Christian Schoenebeck wrote: > >> I'm okay I guess with using g_test_message on 2.62 or newer, and > >> assuming people don't use --tap --verbose on older versions. > > > > Simpler solution: just appending '#' character in front of each printf() > > line, that would be both fine for TAP and regular output: > > http://testanything.org/tap-specification.html#diagnostics > > I'm not sure how it would be simpler than a > > #if !GLIB_CHECK_VERSION(2, 62, 0) > #define qemu_test_message printf > #else > #define qemu_test_message g_test_message > #endif > > but you choose. > > Paolo
Simple yes, but it would not fix the cluttered output problem of g_test_message(). So I'll go with prepending '#' for now, and if one day there will be a public glib function to check for TAP mode, it can easily be adjusted. Best regards, Christian Schoenebeck
