On 08/10/20 15:09, Christian Schoenebeck wrote: >> But doesn't this (and patch 6 as well) break TAP output? Using >> g_test_message + g_test_verbose would be the best of both worlds. > > If there was TAP output then yes, patches 4, 5, 6 would probably break it. > > How/when is TAP output enabled? I don't see any TAP output by default.
With "--tap", but with glib 2.62 it will be enabled by default. For example on Fedora 32: $ ./test-mul64 # random seed: R02S3efb20d48a41e1897cb761e02393c11b 1..2 # Start of host-utils tests ok 1 /host-utils/mulu64 ok 2 /host-utils/muls64 # End of host-utils tests I'm okay I guess with using g_test_message on 2.62 or newer, and assuming people don't use --tap --verbose on older versions. Paolo > which is inappropriate for multi-line messages as these proposed patches do. > > Is that actually a real-life problem? I mean these patches only output > anything if --verbose CL switch is used, and I don't see any TAP output > enabled by default. And the --verbose CL switch is usually just used by > developers for debugging test case issues, isn't it? > > Best regards, > Christian Schoenebeck > >
