On 01.10.20 17:07, Richard Henderson wrote: > On 9/30/20 9:55 AM, David Hildenbrand wrote: >> This series adds support for the "Vector enhancements facility" and bumps >> the qemu CPU model tp to a stripped-down z14. >> >> I yet have to find a way to get more test coverage - looks like some of >> the functions aren't used anywhere yet (e.g., VECTOR FP MAXIMUM), writing >> unit tests to cover all functions and cases is just nasty. But I might be >> wrong - I'm planning to at least test basic functionality of all new added >> instructions. > > This is where RISU can be helpful. Auto-generate 100k random variations, > record known good results on hardware, verify that replay on qemu produces the > same results.
Makes sense, however, some corner cases (e.g., MAX(+0, -O)) still might have to be handled manually. It might take me a while to address the feedback (I'm fairly busy as usual ...). Thanks! -- Thanks, David / dhildenb
